Change the Spezi icon in Onboarding to a star#3
Merged
vishnuravi merged 3 commits intomainfrom Jan 29, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
=======================================
Coverage 86.81% 86.81%
=======================================
Files 21 21
Lines 697 697
=======================================
Hits 605 605
Misses 92 92
Continue to review full report in Codecov by Sentry.
|
PSchmiedmayer
approved these changes
Jan 29, 2025
Member
PSchmiedmayer
left a comment
PSchmiedmayer
left a comment
There was a problem hiding this comment.
Great job with the PR; would be great to resolve the merge conflict before we merge it. Your choice what we should keep here (cats or stars) 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the Spezi icon in Onboarding to a star
♻️ Current situation & Problem
The current Spezi icon is an iPhone which is boring.
⚙️ Release Notes
This PR changes the icon to a star, which is much cooler looking. It also serves as a great demo for how to resolve a merge conflict in class.
📚 Documentation
✅ Testing
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: